Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Add DST teacher for GoogleSGD #4698

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Add DST teacher for GoogleSGD #4698

merged 6 commits into from
Aug 19, 2022

Conversation

jacksukk
Copy link
Contributor

@jacksukk jacksukk commented Aug 1, 2022

Adding this teacher would allow google_sgd to be usable for Dialog State Tracking task.
cc @chinnadhurai

@klshuster klshuster requested a review from moyapchen August 8, 2022 21:22
@klshuster
Copy link
Contributor

klshuster commented Aug 18, 2022

could you please run pytest --force-regen parlai/tasks/google_sgd/test.py and then push the updated/autogenerated test files?

@jacksukk
Copy link
Contributor Author

could you please run pytest --force-regen parlai/tasks/google_sgd/test.py and then push the updated/autogenerated test files?

Done, thanks for reminding! Let me know if there's anything I can do. :)

@klshuster
Copy link
Contributor

klshuster commented Aug 19, 2022

Ahh yes, one more thing: as you've added a new package to requirements.txt, you'll need to update the cache key in our circle config file. You can just do a string replace of '20220805' for each entry to something like '20220819'

@jacksukk
Copy link
Contributor Author

Ahh yes, one more thing: as you've added a new package to requirements.txt, you'll need to update the cache key in our circle config file. You can just do a string replace of '20220805' for each entry to something like '20220819'

Done, Thanks!!

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good on my end, thanks!

@klshuster klshuster merged commit 9484b4c into facebookresearch:main Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants