This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Updated director toxic classifier task #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
approved these changes
Aug 8, 2022
projects/director/tasks/safety.py
Outdated
| else: | ||
| self.classifier = shared['classifier'] | ||
| print('Load the classifier from shared') |
There was a problem hiding this comment.
nit: can we use logging here?
import parlai.utils.logging as logging
logging.info(...)
projects/director/tasks/safety.py
Outdated
|
|
||
| def share(self): | ||
| shared = super().share() | ||
| shared['classifier'] = self.classifier | ||
| if self.classifier: |
There was a problem hiding this comment.
are there instances where this is not instantiated?
There was a problem hiding this comment.
No. I removed it and added an assertion.
|
could you also rebase on main to see if your teacher tests pass? |
Done. |
klshuster
approved these changes
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated toxic classifier task for the director model: