-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Feature: Add the ability to log model artifacts to Weights & Biases #4708
Conversation
feature: add model artifact logging
fix: make wandb logging controlled by cli params
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! If i understand correctly, this is logging the absolute filenames to wandb? if so, maybe we can just include this to be true by default?
I'll also wait to approve until tests pass; you may need to merge main into your branch as we've pushed several fixes recently
…o wandb/model-artifact
merge upstream in to model artifact branch
@klshuster : I've merged upstream main into the branch. |
Thanks for the clarification; in that case, let's leave the default as |
AFAIK, the user limit is 100GB but there are no limits on the model size in practice when logging artifacts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks! failing tests are unrelated
Patch description
This PR adds the ability to log model artifacts to Weights & Biases. Logging model artifacts allows complete reproducibility of the experiments that resulted in the trained model and also allows to reuse the model for finetuning, evaluation and collaboration.
Testing steps
Run the demo training example with the optional arguments to log to wandb.
This should log the model, dictionary, and the trainstats file to Weights & Biases. Here is an example of the logged artifacts from the above command.