Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Refactoring] making the code more Pythonic #4718

Merged
merged 2 commits into from
Aug 7, 2022

Conversation

maldil
Copy link
Contributor

@maldil maldil commented Aug 6, 2022

Patch description
This is not a bug or a feature, but rather a code refactoring to make the code more Pythonic by utilizing the Python 'with' statement.

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maldil
Copy link
Contributor Author

maldil commented Aug 6, 2022

@stephenroller I'm curious if the test failures are known or if this PR contains any failure.

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe CI is broken.

@stephenroller stephenroller merged commit f9da661 into facebookresearch:main Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants