This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
expose retain_graph to user within TorchAgent #4720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Although
loss.backward()
is the norm in usual workflow, there are many instances in which a user might want to pass inretain_graph=True
withinloss
. Considering that parlai doesn't expose the loss api to user, sinceTorchAgent
expects user to callself.backward()
, it would be a good addition to let the user pass inretain_graph=True
if they want to. User can also pass increate_graph=False
,inputs=None
params if they want to, tobackward()
.Testing steps
Other information