Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Mutators] Check if partial_opts is None #4730

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

spencerp
Copy link
Contributor

@spencerp spencerp commented Aug 9, 2022

Patch description
partial_opts is optional and can therefore be None, in which case partial_opt.get('mutators') will throw an exception.

Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spencerp
Copy link
Contributor Author

spencerp commented Aug 9, 2022

So many tests broken right now :(

Comparing with other PRs, though, it doesn't appear that this change introduces any new failures.

@spencerp spencerp merged commit 85c842c into main Aug 9, 2022
@spencerp spencerp deleted the tiny-mutators-bug branch August 9, 2022 15:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants