This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Fix seed from opt in rng sampler of multiwoz_v22 #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moyapchen
approved these changes
Aug 10, 2022
parlai/tasks/multiwoz_v22/agents.py
Outdated
| def __init__(self, opt: Opt, shared=None, *args, **kwargs): | ||
| self.opt = opt | ||
| self.fold = opt["datatype"].split(":")[0] | ||
| opt["datafile"] = self.fold | ||
| self.dpath = os.path.join(opt["datapath"], "multiwoz_v22") | ||
| self.id = "multiwoz_v22" | ||
| if self.opt["seed"]: |
There was a problem hiding this comment.
Would recommend using self.opt.get("seed") to be safe, but otherwise looks fine.
|
Actually thinking about this slightly more - nothing actually adds a flag for "seed" to the argparser. How are you passing the "seed" argument down? |
|
Thanks for replying @moyapchen. I now perform indexing with |
klshuster
reviewed
Aug 18, 2022
klshuster
reviewed
Aug 19, 2022
klshuster
approved these changes
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Since the support for setting seed in
train_model.pyhas been added, we can let user fix the seed in dataset sampler also.Testing steps
Other information