This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[LIGHT] Who Am I - Preventing doubleloading model #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
approved these changes
Aug 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Made a small update to the PACER model plugin that allows for it to be added to other agents (like the
ExpandedAttentionDecoderAndPacerAgent) without doubly loading the base model by instead checking to see if the reranking model has been initialized in some other form.Testing steps
Was consuming 1.2Gb more GPU space than expected and observed logs loading the reranker model twice before this change.
Model works correctly (as tested in the LIGHT game) after this change.
Other information