Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[GPU] Fix Tests #4749

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[GPU] Fix Tests #4749

merged 1 commit into from
Aug 18, 2022

Conversation

klshuster
Copy link
Contributor

Patch description

  1. Expose Precision and Recall to user via TeacherMetrics #4670 introduced an error in several places that used F1Metric.compute
  2. fixing an iterable issue in the bb3 tests

Testing steps
CI

@klshuster klshuster mentioned this pull request Aug 18, 2022
Merged
jxmsML
jxmsML approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@jxmsML jxmsML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klshuster klshuster merged commit 62177d2 into main Aug 18, 2022
@klshuster klshuster deleted the fix_tests branch August 18, 2022 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jxmsML jxmsML jxmsML approved these changes

@stephenroller stephenroller Awaiting requested review from stephenroller

@prajjwal1 prajjwal1 Awaiting requested review from prajjwal1

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klshuster @jxmsML @facebook-github-bot