Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Test] Fix MultiWozv22 testing #4762

Merged
merged 4 commits into from
Aug 22, 2022
Merged

[Test] Fix MultiWozv22 testing #4762

merged 4 commits into from
Aug 22, 2022

Conversation

klshuster
Copy link
Contributor

Patch description
Turns out that multiwoz shuffles the data always. This is fine, but the auto-generated test files were different on my machine vs. circle CI due to different random number generators. This PR forces determinism when in a continuous integration state

Testing steps
CI PLEASE

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping, but others can speak to the test content more

@klshuster klshuster merged commit 7bd31af into main Aug 22, 2022
@klshuster klshuster deleted the multiwoz_play_nice_circleci branch August 22, 2022 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants