This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Added shared embedding option to director model. #4763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaseweston
approved these changes
Aug 22, 2022
jxmsML
reviewed
Aug 23, 2022
projects/director/director_agent.py
Outdated
| super().__init__(opt, dictionary, **kwargs) | ||
|
|
||
| vocabulary_size = len(dictionary) | ||
|
|
||
| decoder_output_dim = self.decoder.out_dim | ||
| self.classifier_heads = nn.Linear(decoder_output_dim, vocabulary_size) | ||
| self.use_shared_embedding = use_shared_embedding |
There was a problem hiding this comment.
if use_shared_embedding is passing from opt, then you can make sure of that `self.use_shared_embedding = opt.get('use_shared_embedding', False)?
There was a problem hiding this comment.
Thanks for the comment. I changed it.
jxmsML
approved these changes
Sep 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option (with flag --director-use-shared-embedding) to share the generation and classification heads of the director. Only two additional parameters are introduced to scale the logits before applying the sigmoid (for the classification).