Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

update to mephisto 2.0.1 for DialCrowd #4773

Merged
merged 1 commit into from
Sep 13, 2022
Merged

update to mephisto 2.0.1 for DialCrowd #4773

merged 1 commit into from
Sep 13, 2022

Conversation

jessicah25
Copy link
Contributor

Patch description
Fixed issue in #4387, where Mephisto was on an outdated version.

@jessicah25
Copy link
Contributor Author

@EricMichaelSmith @JackUrb update on DialCrowd!

JackUrb
JackUrb approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I expected there to be slightly more required for this, one, but I'm glad it was actually a rather easy fix! onSubmit changing from accepting list to dict-only was the one relevant breaking change.

LGTM, thanks for getting this up and running again!

EricMichaelSmith
EricMichaelSmith approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - great to have this, thanks!

@klshuster klshuster merged commit 8872c38 into facebookresearch:main Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMichaelSmith EricMichaelSmith EricMichaelSmith approved these changes

@JackUrb JackUrb JackUrb approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessicah25 @JackUrb @EricMichaelSmith @facebook-github-bot @klshuster