This repository was archived by the owner on Nov 3, 2023. It is now read-only.
[BB3] Fix for R2C2 Model #4786
Merged
[BB3] Fix for R2C2 Model #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note: still need to fix something with memories on the r2c2 agent, will ping when this is resolved |
|
should be good now |
| self.dictionary = agent.dictionary | ||
| else: | ||
| # R2C2 | ||
| self.dictionary = agent.dict |
There was a problem hiding this comment.
question: does it make more sense to replace them all in R2C2?
There was a problem hiding this comment.
While that would make this cleaner, I'd rather just handle it here for now; the R2C2 models all subclass from TGA at some capacity which I think is where we're setting self.dict anyway (and don't want to bubble all the way down to that...)
mojtaba-komeili
approved these changes
Sep 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Addressing issue #4785
Testing steps
Tested with command in #4785 , confirmed it worked