This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[TGA] Factual Nucleus Sampling #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parlai/core/torch_generator_agent.py
Outdated
| @@ -1777,7 +1817,7 @@ def __init__(self, *args, **kwargs): | |||
| raise ValueError('Greedy search can only be run with beam size 1.') | |||
|
|
|||
| def select_paths(self, logprobs, prior_scores, current_length) -> _PathSelection: | |||
| tok_scores, tok_ids = logprobs.max(1) | |||
| tok_scores, tok_ids = logprobs | |||
There was a problem hiding this comment.
I don't know this code well. I don't understand why did you have to change this part? isn't this for greedy? And I don't find any indication that the general code was changed to justify changing this part.
There was a problem hiding this comment.
good catch, this is an artifact, will fix
mojtaba-komeili
approved these changes
Nov 22, 2022
jxmsML
reviewed
Nov 22, 2022
| device=device, | ||
| verbose=verbose, | ||
| dict=self.dict, | ||
| ) |
There was a problem hiding this comment.
is gpu_beam_blocking needed as in other sampling methods?
There was a problem hiding this comment.
yes, will add thanks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Factual nucleus is a decoding method that decays the nucleus sampling
pvalue over time according to a constant factorlambda_decay. Thepvalue resets when encountering a full-stop (whenp_resetisTrue), and there is a lower bound ofomega_boundto whatpcan decay to.Testing steps
Added Factual Nucleus to the existing tree search tests.