This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
None metrics #4902
Merged
None metrics #4902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think this is ok? Maybe CC @stephenroller --> is there a canonical way to handle averages of metrics where in some cases one of the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Running the
projects.cringe.cringe_loss:ContrastiveTransformerGeneratorAgent, noticed some issues about calculating metrics for someNonevalues; this was crashing the model during the training.This was due to dropping some of the values in the Generator Agent (example).
This patch fixes that by ignoring the
Nonevalues in an observation.