This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Custom metrics from compute_loss in TGA (2nd try)
#4913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
reviewed
Dec 15, 2022
|
@klshuster reminding you of this old PR. |
klshuster
approved these changes
Jan 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
The
compute_lossfunction in TGA generates theloss_per_tokenvalues but they are not accessible from outside this method. This PR adds a handle for calculating custom metrics that requireloss_per_token. The added method (custom_loss_metrics) can be overridden by its children to work with theloss_per_tokenandbatchfor generating custom metrics.NOTE: this is cleaned up version of 4905 which became corrupted with other commits after some bad rebase and merge.