Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Fixing the unittests 3.8 #5002

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Fixing the unittests 3.8 #5002

merged 6 commits into from
Apr 11, 2023

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description

  • Skipping one of the trouble making apex tests
  • Retired the starspace model (included a reference to the previous commit that had it).

@klshuster
Copy link
Contributor

could you extract the starspace stuff from this PR?

@mojtaba-komeili
Copy link
Contributor Author

Reverted that commit. Technically this should work if merged after #5003.

@klshuster klshuster merged commit d921d22 into main Apr 11, 2023
@klshuster klshuster deleted the unit38 branch April 11, 2023 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@JackUrb JackUrb Awaiting requested review from JackUrb

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mojtaba-komeili @klshuster @facebook-github-bot