This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fixing ESLint GitHub test #5010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JS lint is back to be the working condition. Changed some of the JS files with the auto format for easy lint fixes. But there are a tone of harder ones that was tedious to resolve. So I left them there for now. The good thing is we are only considering the changes by the user for passing the tests. So our tests from now on should be good. |
klshuster
approved these changes
Apr 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Although ESLint was always green (passing) it was falsely so because of an error that was not running it at all.
This PR tries to fix the issue, run the code, and fix all the JS lint errors.