This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
T5 and GPT2 fixes #5016
Merged
T5 and GPT2 fixes #5016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
approved these changes
Apr 19, 2023
jxmsML
approved these changes
Apr 19, 2023
parlai/agents/hugging_face/t5.py
Outdated
| """ | ||
| Return the dictionary class that this agent expects to use. | ||
|
|
||
| Can be overridden if a more complex dictionary is required. |
There was a problem hiding this comment.
if overriden then do we need to change L150 to be overrideable?
There was a problem hiding this comment.
ahh i had just copied from the original PR, that docstring is out of date let me fix it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Proper fixes that were introduced in #4648 .
Testing steps
Same testing plan as #4648