This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Multilight teacher #5043
Merged
Multilight teacher #5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test updates * lint * extra error for version drifts fixed * pytest_regressions version upgrade for better yaml on unicode * pytest * turning to dict type for the yaml storage * new tests * lint
…rch/ParlAI into multilight-teacher * 'multilight-teacher' of https://github.com/facebookresearch/ParlAI: sphinx install back to normal autoformat task list teacher tests the working version fixed one breaking requirement
klshuster
approved these changes
May 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Adding a custom version of the multilight teachers to the ParlAI side. These teachers only focus on the conversation side of the dataset and do not have the graph elements like their LIGHT counterpart.
Testing steps
Added teachers tests as well as running them manually:
parlai dd -t light_multipartyparlai dd -t light_multiparty --add-location-to-context true --add-personas-to-context true --include-speaker-in-label false --add-speaker-to-context-end true --datatype validparlai dd -t light_multiparty:SpeakerPredictionTeacher