This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
delay import for discache #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34601363 |
wat3rBro
force-pushed
the
export-D34601363
branch
from
055ea7d to
f5ab7b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34601363 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D34601363 |
wat3rBro
added a commit
to wat3rBro/d2go
that referenced
this pull request
Mar 3, 2022
Summary: Pull Request resolved: facebookresearch#185 The `DiskCachedDatasetFromList` was originally in the `d2go/data/utils.py`, so the class is declared by default. Therefore the clean up call (https://fburl.com/code/cu7hswhx) is always called even when the feature is not enabled. This diff move it to a new place and delay the import, so the clean up won't run. Differential Revision: D34601363 fbshipit-source-id: 0754260eeaf335dc0b84ef97525c63e11423b809
wat3rBro
force-pushed
the
export-D34601363
branch
from
f5ab7b7 to
803434b
Compare
Summary: Pull Request resolved: facebookresearch#185 The `DiskCachedDatasetFromList` was originally in the `d2go/data/utils.py`, so the class is declared by default. Therefore the clean up call (https://fburl.com/code/cu7hswhx) is always called even when the feature is not enabled. This diff move it to a new place and delay the import, so the clean up won't run. Reviewed By: tglik Differential Revision: D34601363 fbshipit-source-id: 2e56035361be1a53ebab831f5a98c9862a18b39c
wat3rBro
force-pushed
the
export-D34601363
branch
from
803434b to
ab78255
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34601363 |
wat3rBro
added a commit
to wat3rBro/d2go
that referenced
this pull request
Mar 4, 2022
Summary: Pull Request resolved: facebookresearch#185 The `DiskCachedDatasetFromList` was originally in the `d2go/data/utils.py`, so the class is declared by default. Therefore the clean up call (https://fburl.com/code/cu7hswhx) is always called even when the feature is not enabled. This diff move it to a new place and delay the import, so the clean up won't run. Differential Revision: D34601363 fbshipit-source-id: c1cfc4c7c3799dbc8f21bd58502d2669307f1652
wat3rBro
added a commit
to wat3rBro/d2go
that referenced
this pull request
Mar 4, 2022
Summary: Pull Request resolved: facebookresearch#185 The `DiskCachedDatasetFromList` was originally in the `d2go/data/utils.py`, so the class is declared by default. Therefore the clean up call (https://fburl.com/code/cu7hswhx) is always called even when the feature is not enabled. This diff move it to a new place and delay the import, so the clean up won't run. Differential Revision: D34601363 fbshipit-source-id: cec2420baf9fb2910c5241af57e6527acdc94962
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The
DiskCachedDatasetFromListwas originally in thed2go/data/utils.py, so the class is declared by default. Therefore the clean up call (https://fburl.com/code/cu7hswhx) is always called even when the feature is not enabled. This diff move it to a new place and delay the import, so the clean up won't run.Differential Revision: D34601363