This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
expose example_input argument in setup_qat_model() #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
09d4376 to
d092a89
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
d092a89 to
387e0f0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
387e0f0 to
38b44c3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
38b44c3 to
6056699
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
6056699 to
7d36eed
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
stephenyan1231
force-pushed
the
export-D52760688
branch
from
7d36eed to
b75e1d6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
Summary: Major changes - **example_input** argument in **prepare_fake_quant_model()** is useful in certain cases. For example, in Argos model **custom_prepare_fx()** method under FX graph + QAT setup (D52760682), it is used to prepare example inputs to individual sub-modules by running one forward pass and bookkeeping the inputs to individual sub-modules. Therefore, we export argument **example_input** in **setup_qat_model()** function. - For QAT model, currently we assert # of state dict keys (excluding observers) should be equal to # of state dict keys in the original model. However, when the assertion fails, it does not log useful information for debugging. We make changes to report what are the unique keys in each state dict. Reviewed By: navsud Differential Revision: D52760688
stephenyan1231
force-pushed
the
export-D52760688
branch
from
b75e1d6 to
4d3c1be
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52760688 |
|
This pull request has been merged in 3c6f71b. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Major changes
Differential Revision: D52760688