-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Conversation
The operation `.view_as(an_other_tensor)` is not supported by ONNX, `view(an_other_tensor.size())` is identical and supported. This fix allow to export panoptic models.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Can you add tests for ONNX export for the panoptic model?
Sure, just adapted the existing one. The CI test got killed midway and I can't relaunch it myself apparently, sorry. |
I rerun the CI, let's see what happens |
CI is being killed, maybe it's due to out-of-memory error or something wrong with the ONNX export. Does it work for your locally? |
Sorry for the late reply. Yes it work for me locally, I can export the panoptic models as ONNX and they run fine with onnx-runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's skip this test for now until we increase CI limits and then we re-enable this test.
Once the test is skipped with unittest.skip
it will be good to merge.
Thanks a lot!
Just added your suggestion @fmassa , should be good to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Fix ONNX export for panotpic model The operation `.view_as(an_other_tensor)` is not supported by ONNX, `view(an_other_tensor.size())` is identical and supported. This fix allow to export panoptic models. * Update test_all.py Add onnx export test for panoptic model * fix lint * fix lint * Skip test on OOM CI error
The operation
.view_as(an_other_tensor)
is not supported by ONNX.view(an_other_tensor.size())
is identical and supported, this fix allow to export panoptic models.