Skip to content
This repository has been archived by the owner on Mar 12, 2024. It is now read-only.

Add Dockerfile #26

Merged
merged 1 commit into from
May 31, 2020
Merged

Add Dockerfile #26

merged 1 commit into from
May 31, 2020

Conversation

fatihbaltaci
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 31, 2020
Copy link
Contributor

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I don't know much about Docker, but dont we need to copy the contents of the github repo inside the docker file as well? Or the idea is just to provide minimal dependencies, without the DETR code?

@fatihbaltaci
Copy link
Contributor Author

Hi @fmassa

We can copy the contents of the repo inside the docker container but we can also use docker volume bind mount like this:

docker run -it --gpus all -v `pwd`:/workspace detr:latest

This command binds the working directory pwd on the host system to /workspace path on the container. Whenever we make changes to a file on the host, the change will be reflected in the container immediately.

If we COPY the repo inside the docker container, we would have to build the docker image all the time when we made a change.

In a development environment, it is recommended to use volume bind mounts.

Thanks.

@fmassa
Copy link
Contributor

fmassa commented May 31, 2020

Thanks for the information!

@fmassa fmassa merged commit 7613beb into facebookresearch:master May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants