Replace setup.py with pyproject.toml#30
Open
retornam wants to merge 1 commit intofacebookresearch:mainfrom
Open
Replace setup.py with pyproject.toml#30retornam wants to merge 1 commit intofacebookresearch:mainfrom
retornam wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
[1] Highly recommends using a pyproject.toml file with the [build-system] table due to setup.py deprecating the install, develop, sdit and bdist_wheel commands. This project already uses a pyproject.toml for specific tools, I've migrated the setup.py file to fully take advantage of pyproject.toml build-system using setuptools. Use the following `python -m pip install .` to install without dev dependencies `python -m pip install '.[dev]'` to install with dev dependencies ``` python -m pip install --upgrade build python -m build python -m pip install 'dist/dinov3-0.0.1-py3-none-any.whl' python -m pip install 'dist/dinov3-0.0.1-py3-none-any.whl[dev]' ``` to build and install wheels with and without dev dependencies [1] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#modernize-setup-py-project Signed-off-by: Raymond Etornam <retornam@users.noreply.github.com>
meta-cla
bot
added
the
CLA Signed
Author
|
@patricklabatut @cijose I observed that you have merged other PRs. It is acceptable to comment on PRs that you do not intend to accept, thereby enabling their closure. Leaving PRs open without comments does not encourage others to contribute and may make others feel disrespected/ slighted when other PRs are quickly merged while theirs remain unaddressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1] Highly recommends using a pyproject.toml file
with the [build-system] table due to setup.py
deprecating the install, develop, sdit and bdist_wheel commands.
This project already uses a pyproject.toml for specific tools, I've migrated the setup.py file to fully take advantage of pyproject.toml build-system using setuptools.
Use the following
python -m pip install .to install without dev dependenciespython -m pip install '.[dev]'to install with dev dependenciesto build and install wheels with and without dev dependencies
[1] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/#modernize-setup-py-project