Bugfix: Prevent model weights file duplicate to cache#4
Open
aselimc wants to merge 1 commit intofacebookresearch:mainfrom
Open
Bugfix: Prevent model weights file duplicate to cache#4aselimc wants to merge 1 commit intofacebookresearch:mainfrom
aselimc wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Nevermind, I found them. Yeah, this should be fixed for sure! |
Author
|
As I realized more into it, this behavior is not only for backbones but also for downstream heads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all I use Windows, so this test was only done in Windows, not in Linux
The current implementation creates duplicate model weights in
.cache/torch/even if the weights have already been downloaded. This is caused bytorch.hub.load_state_dict_from_url. As an examplemy local file is copied into cache.
Therefore, I suggest using
torch.loadin case a local path is given to loadstate_dict.