Use number of atoms for batch size #1690
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshuaibii
reviewed
Jan 8, 2026
| def configure_batching( | ||
| self, max_batch_size: int = 32, batch_wait_timeout_s: float = 0.05 | ||
| self, | ||
| max_batch_size: int = 32, |
Contributor
There was a problem hiding this comment.
Is this supposed to still be 32?
mshuaibii
reviewed
Jan 8, 2026
|
|
||
| @serve.batch | ||
| @serve.batch( | ||
| batch_size_fn=lambda batch: sum(sample.natoms.sum() for sample in batch).item() |
Contributor
There was a problem hiding this comment.
naive question - how is @serve.batch working here. how does batch_size_fn get incorporated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next
ray.serverelease will include the option to use a function to determine batch sizes based on input data. ray-project/ray#59059This PR edits our code to use total number of atoms to determine batch sizes in the
BatchPredictServer.