[chore] OSS - get to 100% coverage #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
blefaudeux
commented
Apr 20, 2021
| @@ -390,22 +376,14 @@ def load_state_dict(self, state_dict: Dict[str, Any]) -> None: | |||
| ) | |||
| } | |||
|
|
|||
| # FIXME: pytorch1.5 compatibility, to be removed when 1.5 support ends | |||
| _param_list = list(chain.from_iterable((g["params"] for g in self.param_groups))) | |||
There was a problem hiding this comment.
this dated back to pytorch 1.5, not tested anymore after we changed the CI
blefaudeux
commented
Apr 20, 2021
| @@ -301,20 +301,6 @@ def consolidate_state_dict(self, recipient_rank: int = 0) -> None: | |||
|
|
|||
| logging.debug("State from rank %s received", rank) | |||
|
|
|||
| def local_state_dict(self) -> dict: | |||
| """ .. deprecated:: 0.1.5 | |||
There was a problem hiding this comment.
been deprecated for a while, I think that this should be safe to remove (and there was not much to do with this anyway)
anj-s
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Remove two deprecated code paths which were not covered by unit tests. This should bring OSS code cov to 100%
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃