Refactor parquet dataloader #867
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
| Contains different options that allows to load only a part of the provided dataset. | ||
| """ | ||
|
|
||
| columns: Optional[List[str]] = None |
There was a problem hiding this comment.
I'm not yet sure if it belongs to it
artemru
reviewed
Jan 16, 2025
src/fairseq2/data/parquet/configs.py
Outdated
| """If ``True``, uses Parquet row groups instead of simple partitions which | ||
| are generally smaller. Highly recommended for non-partitioned parquet files.""" | ||
|
|
||
| nb_parallel_fragments: Optional[int] = 5 |
There was a problem hiding this comment.
maybe we could keep it with default=None and add an extra config arg (max_tokens) to be used with dynamic bucketing.
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
Comment on lines
+226
to
+240
| shuffle: bool = True | ||
| """If ``True``, shuffles the dataset samples during the iteration. If ``False`` | ||
| and ``order_by_length`` is ``None``, the batch samples will be produced in | ||
| natural Parquet dataset reading order.""" | ||
|
|
||
| drop_null: bool = True | ||
| """If ``True``, drops rows containing any null value.""" | ||
|
|
||
| seed: int = 123 | ||
| """The RNG seed value for deterministic behavior.""" | ||
|
|
||
| nb_epochs: int = 100 | ||
| """ | ||
| Number of passes over the data before iterations stop | ||
| """ |
There was a problem hiding this comment.
this probably should go to Basic Dataset config (frontend pipeline)
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
| return table | ||
|
|
||
|
|
||
| def load_one_fragment( |
There was a problem hiding this comment.
we have SafeFragment interface for this now
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
artemru
reviewed
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Please describe:
The first attempt to extract and migrate generic parquet dataloader from MERES to fairseq2.
Does your PR introduce any breaking changes? If yes, please list them:
N/A
Check list: