Skip to content

Commit

Permalink
fix open source CI (#3878)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #3878

Looks like D63013820 broke external CI (example failures: https://github.com/facebookresearch/faiss/actions/runs/10965502942/job/30451466102 and https://github.com/facebookresearch/faiss/actions/runs/10964917863 )

with stacktrace
```
Traceback (most recent call last):
  File "/home/runner/work/faiss/faiss/build/faiss/python/setup.py", line 16, in <module>
    shutil.copytree("contrib/torch", "faiss/contrib/torch")
  File "/home/runner/miniconda3/lib/python3.11/shutil.py", line 573, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/miniconda3/lib/python3.11/shutil.py", line 471, in _copytree
    os.makedirs(dst, exist_ok=dirs_exist_ok)
  File "<frozen os>", line 225, in makedirs
FileExistsError: [Errno 17] File exists: 'faiss/contrib/torch'
```

`faiss/contrib/torch'` should be copied over from the line above `faiss/contrib`

Reviewed By: asadoughi

Differential Revision: D63145404

fbshipit-source-id: 0c2df0b3a912aeb48671ca0213a1ea4dd8b44510
  • Loading branch information
mengdilin authored and facebook-github-bot committed Sep 20, 2024
1 parent 4eecd91 commit 03f1d2a
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion faiss/python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
shutil.rmtree("faiss", ignore_errors=True)
os.mkdir("faiss")
shutil.copytree("contrib", "faiss/contrib")
shutil.copytree("contrib/torch", "faiss/contrib/torch")
shutil.copyfile("__init__.py", "faiss/__init__.py")
shutil.copyfile("loader.py", "faiss/loader.py")
shutil.copyfile("class_wrappers.py", "faiss/class_wrappers.py")
Expand Down

0 comments on commit 03f1d2a

Please sign in to comment.