Skip to content

Commit

Permalink
Remove unused variables in faiss/IndexIVF.cpp
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: palmje

Differential Revision: D53779599

fbshipit-source-id: 7f872cecdff078681748d18dfdea78e361a9a72f
  • Loading branch information
r-barnes authored and facebook-github-bot committed Feb 15, 2024
1 parent 53fc617 commit 1b0d274
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion faiss/IndexIVF.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,6 @@ void IndexIVF::search_preassigned(
#pragma omp for schedule(dynamic)
for (int64_t ij = 0; ij < n * nprobe; ij++) {
size_t i = ij / nprobe;
size_t j = ij % nprobe;

scanner->set_query(x + i * d);
init_result(local_dis.data(), local_idx.data());
Expand Down

0 comments on commit 1b0d274

Please sign in to comment.