Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction for /faiss/gpu/utils/MatrixMult-inl.cuh #3026

Closed
DearLabQCM opened this issue Aug 24, 2023 · 1 comment
Closed

Correction for /faiss/gpu/utils/MatrixMult-inl.cuh #3026

DearLabQCM opened this issue Aug 24, 2023 · 1 comment

Comments

@DearLabQCM
Copy link

Summary
A bug in /faiss/gpu/utils/MatrixMult-inl.cuh line174-175

// All sizes must be within int bounds
    FAISS_ASSERT(c.getSize(0) <= std::numeric_limits<int>::max());
    FAISS_ASSERT(c.getSize(1) <= std::numeric_limits<int>::max());

    FAISS_ASSERT(a.getSize(0) <= std::numeric_limits<int>::max());
    FAISS_ASSERT(a.getSize(1) <= std::numeric_limits<int>::max());

    FAISS_ASSERT(a.getSize(0) <= std::numeric_limits<int>::max());
    FAISS_ASSERT(a.getSize(1) <= std::numeric_limits<int>::max());

Maybe it should be

FAISS_ASSERT(b.getSize(0) <= std::numeric_limits<int>::max());
FAISS_ASSERT(b.getSize(1) <= std::numeric_limits<int>::max());

Platform
OS: pop-os 22.04 LTS (ubuntu based)

Faiss version: faiss-cpu 1.7.4

Installed from: pip
Python 3.11.4
numpy 1.24.3

Faiss compilation options: ?

Running on:

[x ] CPU
GPU
Interface:

C++
[x ] Python

@mdouze
Copy link
Contributor

mdouze commented Aug 28, 2023

low pri

mnorris11 pushed a commit to mnorris11/faiss that referenced this issue Jul 2, 2024
Summary: Github issue: facebookresearch#3026

Differential Revision: D59284732
mnorris11 pushed a commit to mnorris11/faiss that referenced this issue Jul 2, 2024
Summary:
Pull Request resolved: facebookresearch#3607

Github issue: facebookresearch#3026

Differential Revision: D59284732
facebook-github-bot pushed a commit that referenced this issue Jul 3, 2024
Summary:
Pull Request resolved: #3607

Github issue: #3026

Reviewed By: mengdilin, junjieqi

Differential Revision: D59284732

fbshipit-source-id: a1100c05e7eab40ae90e910364f9ee1db8b1bc55
abhinavdangeti pushed a commit to blevesearch/faiss that referenced this issue Jul 12, 2024
Summary:
Pull Request resolved: facebookresearch#3607

Github issue: facebookresearch#3026

Reviewed By: mengdilin, junjieqi

Differential Revision: D59284732

fbshipit-source-id: a1100c05e7eab40ae90e910364f9ee1db8b1bc55
ketor pushed a commit to dingodb/faiss that referenced this issue Aug 20, 2024
Summary:
Pull Request resolved: facebookresearch#3607

Github issue: facebookresearch#3026

Reviewed By: mengdilin, junjieqi

Differential Revision: D59284732

fbshipit-source-id: a1100c05e7eab40ae90e910364f9ee1db8b1bc55
aalekhpatel07 pushed a commit to aalekhpatel07/faiss that referenced this issue Oct 17, 2024
Summary:
Pull Request resolved: facebookresearch#3607

Github issue: facebookresearch#3026

Reviewed By: mengdilin, junjieqi

Differential Revision: D59284732

fbshipit-source-id: a1100c05e7eab40ae90e910364f9ee1db8b1bc55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants