Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of search_preassigned #3113

Closed
2 tasks
mdouze opened this issue Oct 24, 2023 · 2 comments
Closed
2 tasks

Incorrect implementation of search_preassigned #3113

mdouze opened this issue Oct 24, 2023 · 2 comments
Labels
enhancement

Comments

@mdouze
Copy link
Contributor

mdouze commented Oct 24, 2023

Summary

Faiss version: 1.7.4

Installed from: anaconda

Running on:

  • [* ] CPU
  • GPU

Interface:

  • C++
  • [ *] Python

ivf_tools.search_preassigned does not support pretransforms in splite of what the doc says.
Besides it would be nice to pass on the store_pairs parameter.

https://github.com/facebookresearch/faiss/blob/main/contrib/ivf_tools.py#L29
@mdouze
Copy link
Contributor Author

mdouze commented Oct 24, 2023

Let's please the submitter!

@mlomeli1 mlomeli1 mentioned this issue Jan 29, 2024
Closed
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 29, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned
2645c3d 
Summary: This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 29, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
b5d7e50 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 29, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
f28434b 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 30, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
640e86d 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 30, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
5076460 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 30, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
d009905 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
mlomeli1 added a commit to mlomeli1/faiss that referenced this issue Jan 30, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (facebookresearch#3225)
9754098 
Summary:

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584
facebook-github-bot pushed a commit that referenced this issue Jan 30, 2024
@mlomeli1 @facebook-github-bot
Index pretransform support in search_preassigned (#3225)
420d25f 
Summary:
Pull Request resolved: #3225

This diff fixes issue [#3113](#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584

fbshipit-source-id: 8189c0a59f957a2606391f22cf3fdc8874110a6e
@mlomeli1
Copy link
Contributor

Solved.

abhinavdangeti pushed a commit to blevesearch/faiss that referenced this issue Jul 12, 2024
@mlomeli1 @abhinavdangeti
Index pretransform support in search_preassigned (facebookresearch#3225)
75dd47a 
Summary:
Pull Request resolved: facebookresearch#3225

This diff fixes issue [facebookresearch#3113](facebookresearch#3113), e.g. introduces support for index pretransform in `search_preassigned`.

Reviewed By: mdouze

Differential Revision: D53188584

fbshipit-source-id: 8189c0a59f957a2606391f22cf3fdc8874110a6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mlomeli1 @mdouze