Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unneeded field, exists in a baseclass #3064

Closed
wants to merge 2 commits into from
Closed

Unneeded field, exists in a baseclass #3064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07428c7
Unneeded field, exists in a baseclass
alexanderguzhva Sep 14, 2023
e74ade6
Merge branch 'main' into baseline_unneeded_field
mlomeli1 Sep 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions faiss/impl/ScalarQuantizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,6 @@ template <class DCClass, int use_sel>
struct IVFSQScannerIP : InvertedListScanner {
DCClass dc;
bool by_residual;
const IDSelector* sel;

float accu0; /// added to all distances

Expand All @@ -1186,8 +1185,9 @@ struct IVFSQScannerIP : InvertedListScanner {
bool store_pairs,
const IDSelector* sel,
bool by_residual)
: dc(d, trained), by_residual(by_residual), sel(sel), accu0(0) {
: dc(d, trained), by_residual(by_residual), accu0(0) {
this->store_pairs = store_pairs;
this->sel = sel;
this->code_size = code_size;
}

Expand Down Expand Up @@ -1259,7 +1259,6 @@ struct IVFSQScannerL2 : InvertedListScanner {

bool by_residual;
const Index* quantizer;
const IDSelector* sel;
const float* x; /// current query

std::vector<float> tmp;
Expand All @@ -1275,10 +1274,10 @@ struct IVFSQScannerL2 : InvertedListScanner {
: dc(d, trained),
by_residual(by_residual),
quantizer(quantizer),
sel(sel),
x(nullptr),
tmp(d) {
this->store_pairs = store_pairs;
this->sel = sel;
this->code_size = code_size;
}

Expand Down