Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group SWIG tests into one file #3807

Closed
wants to merge 1 commit into from

Conversation

mdouze
Copy link
Contributor

@mdouze mdouze commented Aug 29, 2024

Summary:
This groups tests related to SWIG into a single file

removes a dep on platform.Version that does not exist on some envs

Differential Revision: D61959750

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61959750

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61959750

mdouze added a commit to mdouze/faiss that referenced this pull request Aug 30, 2024
Summary:
Pull Request resolved: facebookresearch#3807

This groups tests related to SWIG into a single file

removes a dep on platform.Version that does not exist on some envs

Differential Revision: D61959750
mdouze added a commit to mdouze/faiss that referenced this pull request Aug 30, 2024
Summary:
Pull Request resolved: facebookresearch#3807

This diff re-organizes the tests a bit:

* groups tests related to SWIG into a single file

* enable doxygen test conditionally

* removes a dep on platform.Version that does not exist on some envs

* move a few tests out of build_blocks to avoid it being a catch-all file for uncategorized tests

Differential Revision: D61959750
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61959750

mdouze added a commit to mdouze/faiss that referenced this pull request Sep 5, 2024
Summary:
Pull Request resolved: facebookresearch#3807

This diff re-organizes the tests a bit:

* groups tests related to SWIG into a single file

* enable doxygen test conditionally

* removes a dep on platform.Version that does not exist on some envs

* move a few tests out of build_blocks to avoid it being a catch-all file for uncategorized tests

Reviewed By: asadoughi

Differential Revision: D61959750
Summary:
Pull Request resolved: facebookresearch#3807

This diff re-organizes the tests a bit:

* groups tests related to SWIG into a single file

* enable doxygen test conditionally

* removes a dep on platform.Version that does not exist on some envs

* move a few tests out of build_blocks to avoid it being a catch-all file for uncategorized tests

Reviewed By: asadoughi

Differential Revision: D61959750
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61959750

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 52cf9af.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants