Fix an incorrectly counted the number of computed distances for HNSW #3840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
|
@alexanderguzhva Thanks for fixing! Do you mind adding a unit test for this (either in Python or C++)? (I can also add the test as ramp-up if you are too busy here). |
|
@mengdilin I'm not really sure how to add a practical unit test for this particular case tbh. Maybe, exposing |
|
@mengdilin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mengdilin merged this pull request in 21dfdba. |
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
…acebookresearch#3840) Summary: facebookresearch#3819 A definite bug in my code from the past. The number of reported distances is higher that the number of distances actually computed. Pull Request resolved: facebookresearch#3840 Reviewed By: junjieqi Differential Revision: D62392577 Pulled By: mengdilin fbshipit-source-id: c4d595849cc95e77eb6cd8d499b3128bbe9a6e13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3819
A definite bug in my code from the past.
The number of reported distances is higher that the number of distances actually computed.