Introduce QuantizerTemplateScaling for SQ #3870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
|
@mnorris11 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mnorris11 merged this pull request in 4e30901. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 21, 2024
Summary: #3870 conflicted with changes in #3853 Rebasing D62989543 for PR 3853 internally did not catch the breakage since we don't have avx512 coverage internally unfortunately :( === Test Plan === Tested on a local machine and compilation and C++ tests worked CI for AVX512 and conda build should succeed Pull Request resolved: #3880 Reviewed By: junjieqi Differential Revision: D63156374 Pulled By: mengdilin fbshipit-source-id: 4bf51b2e7795bb55d388a31c79bded742f87d6e9
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary:
replace
``` C++
template <class Codec, bool uniform, int SIMD>
struct QuantizerTemplate {};
```
with
``` C++
enum class QuantizerTemplateScaling { UNIFORM = 0, NON_UNIFORM = 1 };
template <class Codec, QuantizerTemplateScaling SCALING, int SIMD>
struct QuantizerTemplate {};
```
This allows adding more Scalar Quantizer scaling types (such as rowwise or rowwise + non-uniform) in the future.
Pull Request resolved: facebookresearch#3870
Reviewed By: mengdilin
Differential Revision: D63033311
Pulled By: mnorris11
fbshipit-source-id: f62b3dcdf446251229a863fdd9aa5e00d9b02c07
aalekhpatel07
pushed a commit
to aalekhpatel07/faiss
that referenced
this pull request
Oct 17, 2024
Summary: facebookresearch#3870 conflicted with changes in facebookresearch#3853 Rebasing D62989543 for PR 3853 internally did not catch the breakage since we don't have avx512 coverage internally unfortunately :( === Test Plan === Tested on a local machine and compilation and C++ tests worked CI for AVX512 and conda build should succeed Pull Request resolved: facebookresearch#3880 Reviewed By: junjieqi Differential Revision: D63156374 Pulled By: mengdilin fbshipit-source-id: 4bf51b2e7795bb55d388a31c79bded742f87d6e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
with
This allows adding more Scalar Quantizer scaling types (such as rowwise or rowwise + non-uniform) in the future.