Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ignore] test CI #3891

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[ignore] test CI #3891

wants to merge 4 commits into from

Commits on Sep 25, 2024

  1. Begin migrate ScalarQuantizer to simdlib (facebookresearch#3613) 

    Summary:
Pull Request resolved: facebookresearch#3613

As a demo for Mengdi.

The steps to fully migrate to simdlib are:

1. change all function interfaces to use the generic simd8float32 and friends prototypes -- make sure it compiles on fbcode.

2. make sure it also compiles on ARM

3. see which functions can be mirgrated to only use the generic codepath

4. benchmark if the simd emulated path is competitve with the scalar (for platforms without specific SIMD support)

The rationale here is that there are many SIMD instructions that are straightforward, like adding or subtracting registers, they can be put in common between implementations. The only code that may remain with arch-specific intrinsics is where they way of doing things is very different between AVX and NEON.

Differential Revision: D59395882
    @mengdilin @facebook-github-bot
    mengdilin authored and facebook-github-bot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e92e849 View commit details
    Browse the repository at this point in the history

  2. huh 

    Differential Revision: D63404074
    @mengdilin @facebook-github-bot
    mengdilin authored and facebook-github-bot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b7c7bc3 View commit details
    Browse the repository at this point in the history

  3. refactor 

    Differential Revision: D63406173
    @mengdilin @facebook-github-bot
    mengdilin authored and facebook-github-bot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0361b17 View commit details
    Browse the repository at this point in the history

  4. test CI 

    Differential Revision: D63426669
    @mengdilin @facebook-github-bot
    mengdilin authored and facebook-github-bot committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    760fba6 View commit details
    Browse the repository at this point in the history