Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking order for misc/test_blas in Makefile. #489

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Fix linking order for misc/test_blas in Makefile. #489

merged 1 commit into from
Jun 13, 2018

Conversation

beauby
Copy link
Contributor

@beauby beauby commented Jun 13, 2018

Fixes #487.

@mdouze mdouze merged commit f841bba into facebookresearch:master Jun 13, 2018
@beauby beauby deleted the fix-makefile branch June 13, 2018 09:52
@mdouze
Copy link
Contributor

mdouze commented Jun 13, 2018

Weird that we did not catch this before. I assume LIBS is a .a file?

@Enet4 Enet4 mentioned this pull request Jun 13, 2018
Merged
@beauby
Copy link
Contributor Author

beauby commented Jun 13, 2018

@mdouze LIBS is the set of library flags (-lopenblas -llapack etc). The CI does not build/run this target because it is not impacted by faiss, that's why we did not catch it earlier.

CaucherWang pushed a commit to CaucherWang/faiss-learned-termination that referenced this pull request Sep 16, 2022
@beauby @mdouze
Fix linking order for misc/test_blas in Makefile. (facebookresearch#489)
dea6482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beauby @mdouze @facebook-github-bot