Skip to content

[CI/Bugfix]--fix ci to use non-buggy mypy vers, hypothesis vers compat w/python 3.6 #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jturner65
Copy link
Collaborator

Motivation and Context

This PR restricts CI to use expected versions of mypy and hypothesis, since both have recently had changes which either have bugs or dropped support for python 3.6. This PR restricts mypy to v0.910 and hypothesis to 6.29.3 (conda-available version that supports python 3.6).

How Has This Been Tested

Locally all tests pass, and versions are available.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from Skylion007 January 3, 2022 19:55
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 3, 2022
@jturner65 jturner65 requested a review from aclegg3 January 3, 2022 19:55
@jturner65 jturner65 merged commit e132a88 into facebookresearch:main Jan 3, 2022
@jturner65 jturner65 deleted the Bugfix_RestrictCIVersions branch January 3, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants