Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] - better API documentation for NavMeshSettings #1850

Merged
merged 1 commit into from
Sep 1, 2022
Merged

[docs] - better API documentation for NavMeshSettings #1850

merged 1 commit into from
Sep 1, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Aug 31, 2022

Motivation and Context

Added more descriptive API docs for C++ and copied into python bindings for users wishing to customize NavMesh construction.

How Has This Been Tested

NA

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 31, 2022
@aclegg3 aclegg3 requested a review from mathfac August 31, 2022 23:54
@aclegg3 aclegg3 merged commit 2662204 into main Sep 1, 2022
@aclegg3 aclegg3 deleted the navmesh-settings-docs branch September 1, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@mathfac mathfac Awaiting requested review from mathfac

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aclegg3 @Skylion007 @facebook-github-bot