Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle non-indexed collision meshes #1876

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

mosra
Copy link
Collaborator

@mosra mosra commented Sep 29, 2022

Motivation and Context

To avoid this silly assert:

Trade::MeshData::indexType(): the mesh is not indexed

Can happen quite a lot with STL files, which are also quite likely to be referenced from URDFs. See also https://cvmlp.slack.com/archives/CFN5TAUSD/p1663172543970699 for another report of the same problem -- and apologies in case it's already being fixed elsewhere, I couldn't find any related PR.

Also contains an unrelated change cleaning up a no-longer-used define (I suppose that was for the long-gone io functionality that was replaced with Corrade's Utility::Path).

How Has This Been Tested

Hit this myself when loading a random old version of the Hab Fetch robot. After the fix it no longer blows up.

Can happen quite a lot with STL files, which are quite likely to be
referenced from URDFs.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 29, 2022
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@mosra mosra merged commit 51fa783 into main Sep 29, 2022
@mosra mosra deleted the non-indexed-collision-meshes branch September 29, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants