Properly handle non-indexed collision meshes #1876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To avoid this silly assert:
Can happen quite a lot with STL files, which are also quite likely to be referenced from URDFs. See also https://cvmlp.slack.com/archives/CFN5TAUSD/p1663172543970699 for another report of the same problem -- and apologies in case it's already being fixed elsewhere, I couldn't find any related PR.
Also contains an unrelated change cleaning up a no-longer-used define (I suppose that was for the long-gone
io
functionality that was replaced with Corrade'sUtility::Path
).How Has This Been Tested
Hit this myself when loading a random old version of the Hab Fetch robot. After the fix it no longer blows up.