Replay Batch Renderer

[0mdc]

Motivation and Context

This changeset is a continuation of the work started in #1745 by @eundersander (see facebookresearch/habitat-lab#863 for full context).

How Has This Been Tested

ReplayBatchRendererTest is successful.

Types of changes

• Docs change / refactoring / dependency upgrade
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have completed my CLA (see CONTRIBUTING)
• I have added tests to cover my changes.
• All new and existing tests passed.

[eundersander]

LGTM!

[mosra]

Just making sure -- is this meant to eventually also abstract away from using a SceneNode or that's to be done in a later PR?

On my side I have some really dirty code that attempts to make that abstraction, by storing an ID inside a SceneNode*. If you would find it useful, I can share the patch.

[0mdc]

@mosra

Just making sure -- is this meant to eventually also abstract away from using a SceneNode or that's to be done in a later PR?

This is intended to help abstracting away the scene graph, however this will be done in a later PR.

On my side I have some really dirty code that attempts to make that abstraction, by storing an ID inside a SceneNode*. If you would find it useful, I can share the patch.

I'd love to see your vision on this.

[mosra]

FYI you could use Magnum's Image2D instead of a buffer + an image view. It's an owning container so there's no need to maintain a separate buffer for it, and it's implicitly convertible to a [mutable]ImageView2D as well.

[0mdc]

I'll move on with this changeset and improve the test case when the real batch renderer will be integrated here.