Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pybind11 to v2.10.2 #1974

Merged
merged 2 commits into from
Dec 22, 2022
Merged

Update pybind11 to v2.10.2 #1974

merged 2 commits into from
Dec 22, 2022

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Update pybind11 to v2.10.2, mostly cmake fixes and other small bugfixes
  • Also some minor typing improvements and added options as well.

How Has This Been Tested

Types of changes

  • Dependency update
  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 21, 2022
0mdc
0mdc approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Skylion007 Skylion007 merged commit 13c260b into main Dec 22, 2022
@jturner65 jturner65 deleted the skylion007/update-pybind11-v2-10-2 branch November 29, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0mdc 0mdc 0mdc approved these changes

@jturner65 jturner65 Awaiting requested review from jturner65

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@eundersander eundersander Awaiting requested review from eundersander

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @0mdc @facebook-github-bot