Clear replay renderer when all instances are deleted. #1976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The batch renderer currently cannot delete individual instances. Because of this, it quickly reaches internal limits when repeatedly changing scenes. The batch renderer can however delete all instances at once.
This changeset clears the frame when the player detects that the applied keyframe is deleting all instances.
This implementation is preferred to an explicit
clearFrame
keyframe flag as it doesn't force the implementer (blender script, etc) to delete its instances in a specific way. However, it cannot detect leaking instances from a misused recorder.How Has This Been Tested
Tested in python viewer by repeatedly changing scenes.
Types of changes
Checklist