Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Fix] Bump black and isort. #2000

Merged
merged 3 commits into from
Feb 8, 2023
Merged

[CI Fix] Bump black and isort. #2000

merged 3 commits into from
Feb 8, 2023

Conversation

0mdc
Copy link
Contributor

@0mdc 0mdc commented Feb 8, 2023 •
edited
Loading

Motivation and Context

This bumps black to 23.1.0 and isort to 5.11.5. The subsequent formatting changes are applied.

This was done in Habitat-lab already here, here and here.

How Has This Been Tested

Tested on CI.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 8, 2023
@0mdc 0mdc changed the title [CI Fix] Bump Black to 23.1. [CI Fix] Bump black and isort. Feb 8, 2023
@0mdc 0mdc marked this pull request as ready for review February 8, 2023 14:28
@0mdc 0mdc mentioned this pull request Feb 8, 2023
Merged
aclegg3
aclegg3 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@aclegg3 aclegg3 merged commit 1880009 into main Feb 8, 2023
@aclegg3 aclegg3 deleted the ci-fix-black branch February 8, 2023 20:16
aclegg3 pushed a commit that referenced this pull request Feb 10, 2023
@0mdc @aclegg3
[CI Fix] Bump black and isort. (#2000)
8ee2210 
* Bump black version to 23.1.0.

* Apply black 23.1.0 formatting changes.

* Bump isort to 5.11.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 aclegg3 approved these changes

@vincentpierre vincentpierre Awaiting requested review from vincentpierre

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0mdc @aclegg3 @facebook-github-bot