Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Magnum with new MaterialTools and improved glTF import/export #2015

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

mosra
Copy link
Collaborator

@mosra mosra commented Feb 23, 2023

Motivation and Context

About 15k lines of hot new stuff implemented since #1999 two weeks ago:

How Has This Been Tested

🚧 The last feature mentioned above has yet to pass through my own CIs, which is why the PR is marked as a draft. Once I'm sure it passes all my tests, I'll unblock the PR.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 23, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Thank you.

@mosra mosra requested a review from Skylion007 February 23, 2023 17:11
jturner65
jturner65 approved these changes Feb 23, 2023
@mosra
Copy link
Collaborator Author

mosra commented Feb 23, 2023

Update re the ✨ magic shader flag ✨: I have it confirmed working locally -- no limits hit even with a 3 GB composite file listed below --, @0mdc is now testing it with the Python viewer.

image

It however still needs some work, testing, documentation polishing (I underestimated a bit, heh), so it probably won't be ready by tomorrow. Feel free to "undraft" and merge the PR if you need anything from it, I can submit the ✨ magic shader flag ✨ separately after.

@0mdc 0mdc marked this pull request as ready for review February 24, 2023 14:58
@0mdc 0mdc merged commit c7f4d13 into main Feb 24, 2023
@johncruyff14
Copy link

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants