Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BE Week]Remove shadowmanager/variance shadow map code #2139

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR removes the variance shadow map-based shadow functionality demo code. It was not being used, required expansion, and we have decided to pursue other routes for shadow-like graphical performance, planning on integrating HBAO into the simulator in the next few months.

How Has This Been Tested

Current c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from 0mdc June 27, 2023 16:17
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 27, 2023
@0mdc
Copy link
Contributor

0mdc commented Jun 28, 2023

Here are some remaining references:

pbrUniforms.glsl L31
gaussianFilter.frag L32
esp/gfx/PbrShader.h L640

@jturner65 jturner65 force-pushed the BE_RemoveShadowManager branch from 5012f38 to 1720b92 Compare June 28, 2023 23:02
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65 jturner65 merged commit afc10ad into main Jul 3, 2023
@jturner65 jturner65 deleted the BE_RemoveShadowManager branch July 3, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants