Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE Week] Add Ruff pre-commit hook #2156

Merged
merged 4 commits into from
Jul 17, 2023
Merged

Conversation

Skylion007
Copy link
Contributor

Motivation and Context

  • Ruff is a faster, more featureful reimplementation of flake8 in rust that also provides autofixes

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 11, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@naokiyokoyama
Copy link
Contributor

naokiyokoyama commented Jul 12, 2023

Since ruff does everything that autoflake, flake8, and isort do, but faster, should these three be removed from the toml file and the precommit yaml now?

@Skylion007
Copy link
Contributor Author

@naokiyokoyama autoflake is redundant. Not all the flake8 rules are implemented in ruff yet, same with isort (although we may be using all the features in isort that ruff implements).

@Skylion007 Skylion007 merged commit d4daec4 into main Jul 17, 2023
@jturner65 jturner65 deleted the skylion007/add-ruff-precommit branch November 29, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants