Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[BUGFIX] Background renderer should not create extra contexts #2180

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR fixes an issue where an additional GL context was being created in the Background Renderer, which was causing problems, including seg faults with examples/tutorials/async_rendering.py

How Has This Been Tested

Existing C++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Aug 8, 2023
@0mdc
Copy link
Contributor

0mdc commented Aug 8, 2023

Is the code from examples/tutorials/async_rendering.py tested somewhere?

Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65
Copy link
Contributor Author

Is the code from examples/tutorials/async_rendering.py tested somewhere?

Yes, it is part of the python tests. test_example.py

@jturner65 jturner65 merged commit bb0b572 into main Aug 9, 2023
@jturner65 jturner65 deleted the BugFix_AsyncRender branch August 9, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants